Robin Hourahane / Improved-mbed-rpc

Improved RPC library with added bounds checking to stop memory corruption, removed memory leaks, Arduino pin names, better object discovery.

Fork of mbed-rpc by mbed official

I have added bounds checking in both Argument and Reply classes to stop existing buffer over-runs in both classes.

Added the ability to discover the name and class of an RPC object to allow better discovery of existing objects on a server. Removed a memory leak with externally created RPC objects. Ensured consistency so that externally created objects can't be deleted using the RPC interface and are correctly listed after RPC::clear.

Updated RPCVariable to use references instead of pointers to ensure that the compiler checks that there is always a valid backing variable. Also removed RPC new/delete functionality as this is not valid. Added a specialisation of RPCVariable to allow for strings to be read and written via RPC.

Added Arduino pin names to parse_pins, currently only for FRDM boards but same code should work for others just need to add them to the #ifdef.

Arguments.h

Committer:
rhourahane
Date:
2015-03-30
Revision:
10:7511acfaa62d
Parent:
1:6919289a5946

File content as of revision 10:7511acfaa62d:

/* mbed Microcontroller Library
 * Copyright (c) 2006-2013 ARM Limited
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
#ifndef ARGUMENTS_H
#define ARGUMENTS_H

#include "platform.h"
#include "parse_pins.h"

namespace mbed {

#define RPC_MAX_STRING  128
#define RPC_MAX_ARGS     16

class Arguments {
public:
    Arguments(const char* rqs);

    template<typename Arg>
    Arg   getArg(void);

    char *obj_name;
    char *method_name;

    int   argc;
    char* argv[RPC_MAX_ARGS];

private:
    // This copy can be removed if we can assume the request string is
    // persistent and writable for the duration of the call
    char  request[RPC_MAX_STRING + 1];
    int index;
    char* search_arg(char **arg, char *p, char next_sep);
};

class Reply {
public:
    Reply(char* r);

    template<typename Data>
    void putData(Data d);

private:
    void separator(void);
    bool first;
    char* reply;
    int space;
};


} // Namespace mbed

#endif